----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9814/#review17620 -----------------------------------------------------------
Ship it! src/slave/flags.hpp <https://reviews.apache.org/r/9814/#comment37365> For the same reason we should s/cgroups_hierarchy_root/cgroups_hierarchy/, I'd like to s/cgroups_root_cgroup/cgroups_root/. Also, I'd prefer s/TEST_HIERARCHY/TEST_CGROUPS_HIERARCHY/ and s/TEST_ROOT_CGROUP/TEST_CGROUPS_ROOT/ so that they match the flag names. Arguably we should get rid of the constants anyway since that is what the flags are for! - Benjamin Hindman On March 8, 2013, 2:46 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9814/ > ----------------------------------------------------------- > > (Updated March 8, 2013, 2:46 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Pulled out some cgroups test fixtures into test utils, and made them generic, > so that they can be re-used by other tests. > > Also the root cgroup can be configured via flag, helping cgroups isolation > module related tests to use a different cgroup (e.g. "mesos_tests"). > > NOTE: This is based of my earlier cgroups review: > https://reviews.apache.org/r/9806/ > > > Diffs > ----- > > src/slave/cgroups_isolation_module.cpp > c7ca32c8122ce97f77a5ba68f6ad3dc1f17704f7 > src/slave/flags.hpp 9cd436cae5772b906b3566eb1f344904d5894214 > src/tests/cgroups_tests.cpp ed419eb174a095786fb6de9e181d42587e5b40e2 > src/tests/utils.hpp 0d4edad4787f92f86b1486b6b510f46a62d7d541 > > Diff: https://reviews.apache.org/r/9814/diff/ > > > Testing > ------- > > sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*Cgroups*" --verbose > > > Thanks, > > Vinod Kone > >
