----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8762/#review17705 -----------------------------------------------------------
src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/8762/#comment37601> more info in the comment. src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/8762/#comment37602> return Future::failed(). - Vinod Kone On March 11, 2013, 5:54 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8762/ > ----------------------------------------------------------- > > (Updated March 11, 2013, 5:54 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Properly recovers and reconnects with executors. > > Also, recovers isolation module. > > This is pretty much the whole of recovery! (I'm going to send out another > tiny review for properly doing incompatible upgrades) > > > Diffs > ----- > > src/exec/exec.cpp 821a94fab1f5969183ecf9e28d7b6bc10920db24 > src/launcher/launcher.hpp ead58c0f60b6bff532f241a224b547b25e292175 > src/launcher/launcher.cpp f2d68c5fd1201b75c5a8f96599d7fb36516687fb > src/launcher/main.cpp e90df85ae433431defdd251490c74a482a58f743 > src/messages/messages.proto 815fcbbcb4a8643f50950a294cedf7281b2a187f > src/slave/cgroups_isolation_module.hpp > 11244802b3210ef1a6900b978faf8bbcaa00266c > src/slave/cgroups_isolation_module.cpp > 9395d9cd6cf2ac7a720480b778836eb1d704e00d > src/slave/constants.hpp dc5b9877e2608f6806f13b6ef4d133b6fddaece4 > src/slave/constants.cpp ecb96fd42afdb74aca394411c6ff60276f509cfd > src/slave/flags.hpp b2441c773b13365a14b3daad4f81ae1ec0733439 > src/slave/isolation_module.hpp d7cc02b8ea0cde591ee61059efd79fbacaa74769 > src/slave/lxc_isolation_module.hpp 6be99038fb547e43e74ef5469f2339bbe82017cf > src/slave/lxc_isolation_module.cpp 1ed3c87f884089e032bba2ed89be109abe6c1c13 > src/slave/process_based_isolation_module.hpp > 6a4e6aef9ab4b13cce9341f6f35c6b24e6f8fde7 > src/slave/process_based_isolation_module.cpp > ff98d105af675dfc66070feaa43b42c1aa438fd8 > src/slave/slave.hpp 11f17aef6d5deefe83b2d4706e4b8b24adaac5f4 > src/slave/slave.cpp 889e9fe7671c9b158486fd7b85fef139c4ab8c9b > src/slave/state.cpp 2688567719c5b12f1d8a56fa6193c11d4077685b > src/slave/status_update_manager.hpp PRE-CREATION > src/slave/status_update_manager.cpp PRE-CREATION > src/tests/slave_recovery_tests.cpp PRE-CREATION > src/tests/utils.hpp d3efa58ef62383af9eb051b23feb950ba6a4f4e3 > > Diff: https://reviews.apache.org/r/8762/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
