----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9868/#review17715 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On March 12, 2013, 4:46 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9868/ > ----------------------------------------------------------- > > (Updated March 12, 2013, 4:46 a.m.) > > > Review request for mesos, Thomas Marshall, Vinod Kone, and Ben Mahler. > > > Description > ------- > > I like the idea of keeping the filter update code with the "environment" > code, since the filter is updated based on the environment. There is also a > nice guarantee that this code will get invoked before RUN_ALL_TESTS because > the environment instance has to be added before RUN_ALL_TESTS is invoked. > > > Diffs > ----- > > src/tests/environment.hpp f1e61fec73f12a365ffe3baa12594ab205557300 > src/tests/environment.cpp bda72ae0310e74015f3fbde50fecbf6515276e81 > > Diff: https://reviews.apache.org/r/9868/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
