----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9858/#review17768 -----------------------------------------------------------
third_party/libprocess/src/process.cpp <https://reviews.apache.org/r/9858/#comment37705> socket? I just see a 'fd' here? third_party/libprocess/src/process.cpp <https://reviews.apache.org/r/9858/#comment37704> s/, this/. This/ or s/this avoids/avoiding/ third_party/libprocess/src/tests/io_tests.cpp <https://reviews.apache.org/r/9858/#comment37706> Assuming this is going to fail, 1 second seems to be long? Why not 0.1 seconds? third_party/libprocess/src/tests/io_tests.cpp <https://reviews.apache.org/r/9858/#comment37707> ditto third_party/libprocess/src/tests/io_tests.cpp <https://reviews.apache.org/r/9858/#comment37708> Why 3 seconds !? - Vinod Kone On March 12, 2013, 1:12 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9858/ > ----------------------------------------------------------- > > (Updated March 12, 2013, 1:12 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See bug description, this re-enables the buffered read tests. > > > This addresses bug MESOS-326. > https://issues.apache.org/jira/browse/MESOS-326 > > > Diffs > ----- > > third_party/libprocess/src/process.cpp > 889b380f275e2d63d9fac0cd03fc0587011613bb > third_party/libprocess/src/tests/io_tests.cpp > 31e2b71121deada6c252e5f71bc6e60af955d6e1 > > Diff: https://reviews.apache.org/r/9858/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
