----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9847/#review17794 -----------------------------------------------------------
Ship it! LGTM! src/linux/cgroups.hpp <https://reviews.apache.org/r/9847/#comment37745> "... or if we failed to destroy any of the cgroups." So, the comment leaves me wondering: how can you just "remove" a cgroup? Don't you have to kill all the tasks first? My expectation was that destroy always tried to kill all the tasks in a cgroup. The freezer subsystem just made that more reliable. If this isn't the current implementation we should put a big TODO to eventually do it this way. src/linux/cgroups.hpp <https://reviews.apache.org/r/9847/#comment37746> s/cleaning up all/destroying all/ src/tests/utils.hpp <https://reviews.apache.org/r/9847/#comment37748> Final question: what's the value in using TEST_CGROUPS_ROOT? - Benjamin Hindman On March 13, 2013, 4:52 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9847/ > ----------------------------------------------------------- > > (Updated March 13, 2013, 4:52 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > With the new fixtures, one can implement a typed test, for isolation modules, > as follows. > > template <typename T> > class SlaveRecoveryTest : public IsolationTest<T> > { > T isolationModule; > }; > > > Diffs > ----- > > src/linux/cgroups.hpp 56c6eb7ea130acd951eabdb42dafae4f2cdcff4d > src/linux/cgroups.cpp 480ae228a1365afa60c9f88c1f31f48e3a5eb294 > src/slave/cgroups_isolation_module.hpp > 11244802b3210ef1a6900b978faf8bbcaa00266c > src/slave/cgroups_isolation_module.cpp > 9395d9cd6cf2ac7a720480b778836eb1d704e00d > src/tests/cgroups_tests.cpp 65c2bfaec1dd5adc879a206aa97592ae7f0c0074 > src/tests/utils.hpp d3efa58ef62383af9eb051b23feb950ba6a4f4e3 > > Diff: https://reviews.apache.org/r/9847/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
