----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9826/#review17919 -----------------------------------------------------------
Ship it! src/slave/main.cpp <https://reviews.apache.org/r/9826/#comment37923> We need to tell the SREs to make this change in puppet. Mainly because the default here is different from whats running on cluster! Raising an issue, so you will acknowledge :) - Vinod Kone On March 14, 2013, 8:54 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9826/ > ----------------------------------------------------------- > > (Updated March 14, 2013, 8:54 p.m.) > > > Review request for mesos, Vinod Kone and Ben Mahler. > > > Description > ------- > > This also kills rotting code, including the "isolation module factory", > solaris stuff, and lxc. > > > Diffs > ----- > > src/Makefile.am 2947a0748bee19e8413eed13c845b39d006bde09 > src/examples/balloon_executor.cpp 7d9cad28f1b95e7f492b98d913876432f6389357 > src/launcher/launcher.hpp d9e7b6bd1f8dec9a99c1e6f0fca7af1315b6eb93 > src/launcher/launcher.cpp 657977d0e6ced22c3f04686e997c2e02ce10ed64 > src/launcher/main.cpp c9b583df16f52893d3d0ae283d0071d7331f5cd8 > src/local/local.cpp af4b5e1af7be94114c09464eba93b18276678ef5 > src/slave/cgroups_isolation_module.hpp > 517566a13c59cb93451668225bad806cf98970c2 > src/slave/cgroups_isolation_module.cpp > 708175b0c1f55e8d9243b96bd5f3722942332b6b > src/slave/cgroups_isolator.hpp PRE-CREATION > src/slave/cgroups_isolator.cpp PRE-CREATION > src/slave/isolation_module.hpp b53b3abfea0bff7c5ee9def38306d1cd9508f2da > src/slave/isolation_module.cpp a881bab582c30e2812bcdaf649a2e6458cc23c11 > src/slave/isolation_module_factory.hpp > 9e1fef4324b6657f9887d2703be4a3257ab71f85 > src/slave/isolation_module_factory.cpp > 649894549f00c4ca231341ecaf2a8e5ab71d717c > src/slave/isolator.hpp PRE-CREATION > src/slave/isolator.cpp PRE-CREATION > src/slave/lxc_isolation_module.hpp 8eb7bed778980d988d3fafe58637666363237730 > src/slave/lxc_isolation_module.cpp a936b29cc74e5b1e1e64e3277b46ab830cb3334f > src/slave/main.cpp a7567f7f923f289e8e3da53022a46031bb3bcd1d > src/slave/monitor.hpp 9fd92dc05524fb03728ae082e83b3fd9736d8e84 > src/slave/monitor.cpp 18fbd48f2b9759fc950e43a2c61f3d27119e24c7 > src/slave/process_based_isolation_module.hpp > 52df928c1c0602a45816223fd7744aa805f852be > src/slave/process_based_isolation_module.cpp > 24c8a1b8940e4fb8acd7aa74ad66813620cae526 > src/slave/process_isolator.hpp PRE-CREATION > src/slave/process_isolator.cpp PRE-CREATION > src/slave/projd.cpp 663c531f27da5ff7c4e25aafd8b105492331d203 > src/slave/slave.hpp f9a438ab850ef9a3fea68fb2e72957304654b200 > src/slave/slave.cpp 53eccb91b158f936763ab5d03d3a6f50fef1d596 > src/slave/solaris_project_isolation_module.hpp > 18c010922231f9c4a7fa90526243ea00ce83e55e > src/slave/solaris_project_isolation_module.cpp > 388a0460db1e6449cc1d40cddf06e141d9bdf58d > src/tests/allocator_tests.cpp b953cd1b4a772a5de956d1354eafa6dd23bdd4ca > src/tests/allocator_zookeeper_tests.cpp > 3f7020290029f28ab9237b2941c4977ca496fbe7 > src/tests/balloon_framework_test.sh > af4658b59722c5c5ea3d7e7218a9fc0913835292 > src/tests/cgroups_isolation_tests.cpp > 2fb620789d19c17082a305981bfe26122e5f25f2 > src/tests/cgroups_isolator_tests.cpp PRE-CREATION > src/tests/cgroups_tests.cpp 6b0b46cfc67743e235519801ede0d763e04c60c3 > src/tests/environment.cpp 49027989be17f923b01a254325e4c1d6aaf80a24 > src/tests/exception_tests.cpp 31abb93bd92324194ee3ac272424a5937eacacb9 > src/tests/fault_tolerance_tests.cpp > 16031bcab6c7f66b8a0e5e649a5bfeea7c8f6ad0 > src/tests/gc_tests.cpp fbdd6d650751dd1ef241c86bcee8a383d73d9a4b > src/tests/lxc_isolation_tests.cpp 30e7459069a75fecd3ea976ff02e7cf4f114089a > src/tests/master_detector_tests.cpp > 787ba192d187b7829053450867e05850fa8b862f > src/tests/master_tests.cpp 6d424d80dac6576c98372118b958c68503500cbf > src/tests/monitor_tests.cpp a1857dc58bf5bfc7821d328ed13575865de8020e > src/tests/resource_offers_tests.cpp > 44eaf0d262e8ae57c5aa5c0f00f1755311533608 > src/tests/slave_recovery_tests.cpp bfe865970009450e96e5f872008d3818796f1129 > src/tests/status_update_manager_tests.cpp > 2c1e0629b11d69a1c08b25cfca6f6342605b676f > src/tests/utils.hpp 7b8bd9f145cdf86910abdcd7bffe9cfd2c61c8cd > > Diff: https://reviews.apache.org/r/9826/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
