> On March 14, 2013, 9:44 p.m., Thomas Marshall wrote: > > src/tests/environment.cpp, line 90 > > <https://reviews.apache.org/r/9920/diff/1/?file=270420#file270420line90> > > > > This needs to be strings::contains as above and not == since tests will > > actually list their parameter as somethings more like > > "mesos::intermal::slave::CgroupsIsolationModule" > > > > With this patch submitted, we have again regressed to having the > > SlaveRecoveryTests fail on Ubuntu.
Ah, thanks for catching this Thomas! I'll prepare a fix. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9920/#review17923 ----------------------------------------------------------- On March 14, 2013, 5:39 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9920/ > ----------------------------------------------------------- > > (Updated March 14, 2013, 5:39 a.m.) > > > Review request for mesos, Vinod Kone and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/environment.cpp 49027989be17f923b01a254325e4c1d6aaf80a24 > > Diff: https://reviews.apache.org/r/9920/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
