----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9945/#review17965 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/9945/#comment37968> foreachvalue (Task* task, utils::copy(slave->tasks)) { if (!ids.contains(task->framework_id())) { ...; } } src/master/master.cpp <https://reviews.apache.org/r/9945/#comment37967> But even the local framework object would be insufficient if that master failed over to another one right? src/master/master.cpp <https://reviews.apache.org/r/9945/#comment37965> if (slave->executors.contains(framework->id)) { foreachkey (const ExecutorID& executor, slave->executors[framework->id]) { ...; } } - Benjamin Hindman On March 15, 2013, 4:54 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9945/ > ----------------------------------------------------------- > > (Updated March 15, 2013, 4:54 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Sending this out before I write any tests, to get feedback on the semantics. > > > Diffs > ----- > > src/master/master.hpp c9b4b3f3ff562b75f74a605f3cd7a6957f00d9e7 > src/master/master.cpp ecefc8b9fc14b4f0950b053d47bb2d6e464f8724 > > Diff: https://reviews.apache.org/r/9945/diff/ > > > Testing > ------- > > None yet. Will update this diff when I write one. > > > Thanks, > > Vinod Kone > >
