----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10019/#review18115 -----------------------------------------------------------
Ship it! src/slave/slave.hpp <https://reviews.apache.org/r/10019/#comment38239> add more info, why src/slave/slave.hpp <https://reviews.apache.org/r/10019/#comment38238> use a multi-hashmap of tasks->updates. src/slave/slave.hpp <https://reviews.apache.org/r/10019/#comment38240> kill this. src/slave/slave.cpp <https://reviews.apache.org/r/10019/#comment38241> add more info for why we dont' care for updates when framework is shutting down. src/slave/slave.cpp <https://reviews.apache.org/r/10019/#comment38242> make acks a hashset of UUIDs. - Vinod Kone On March 19, 2013, 6:15 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10019/ > ----------------------------------------------------------- > > (Updated March 19, 2013, 6:15 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/slave.hpp dadd06850565d07b46cea2f581661fb57a121118 > src/slave/slave.cpp 912499e4cb34afa9bcc1556fd9536581001933ca > src/tests/gc_tests.cpp a9a7a439702ab87d5384c2d1b8afc0b17dab4e62 > > Diff: https://reviews.apache.org/r/10019/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
