----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9996/#review18134 -----------------------------------------------------------
Ship it! Can you run this repetitively with a lot of repetitions to check for flakiness? ./bin/mesos-tests.sh --gtest_filter="*ResourcesUnused*" -verbose --gtest_repeat=300 --gtest_break_on_failure - Ben Mahler On March 19, 2013, 10:14 p.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9996/ > ----------------------------------------------------------- > > (Updated March 19, 2013, 10:14 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > In the ResourcesUnused test, a framework receives an offer and then launches > a task with it that uses less than the entire offer, to check that the unused > resources are being returned and reoffered correctly. Since we don't care > that the task is actually launched by the executor, just that the master > processes the task launching, the test was written under the assumption that > it would exit before the executor was registered and received the launchTask > call. This doesn't always happen, though, so the test was sometimes failing. > > This patch adds in expectations on the executor for the registered and > launchTask calls, though since we still don't care whether or not they > actually happen they are both cardinality AtMost(1). > > > This addresses bug MESOS-378. > https://issues.apache.org/jira/browse/MESOS-378 > > > Diffs > ----- > > src/tests/allocator_tests.cpp 4ae8bfd > > Diff: https://reviews.apache.org/r/9996/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Thomas Marshall > >
