----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10074/#review18286 -----------------------------------------------------------
Ship it! Can you add a comment above close() like we do in write? - Vinod Kone On March 22, 2013, 4:17 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10074/ > ----------------------------------------------------------- > > (Updated March 22, 2013, 4:17 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See the mktemp documentation for the warnings. > http://pubs.opengroup.org/onlinepubs/000095399/functions/mktemp.html > > > Diffs > ----- > > third_party/libprocess/third_party/stout/include/stout/os.hpp > 905e783f837395dd8d3db16e487845c120ae8c91 > > Diff: https://reviews.apache.org/r/10074/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
