> On March 22, 2013, 9:46 p.m., Vinod Kone wrote: > > src/tests/utils.hpp, line 113 > > <https://reviews.apache.org/r/10077/diff/1/?file=273889#file273889line113> > > > > Why did you need to add this? > > > > Can't tests just do os::cwd() ?
Dropping as discussed (this is private in visibility, only used to be able to delete the sandbox in TearDown()). - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10077/#review18288 ----------------------------------------------------------- On March 22, 2013, 7:12 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10077/ > ----------------------------------------------------------- > > (Updated March 22, 2013, 7:12 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > The TemporaryDirectoryTest fixture leaks the sandbox directories. > > > Diffs > ----- > > src/tests/utils.hpp 50203579f1ea14ee751c12a373047e9295e4ebb3 > src/tests/utils.cpp 910396d872a8732ed53da353c4225dd81ff10b32 > > Diff: https://reviews.apache.org/r/10077/diff/ > > > Testing > ------- > > make check > verified this was cleaning up > > > Thanks, > > Ben Mahler > >
