----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10179/#review18528 -----------------------------------------------------------
Ship it! src/slave/gc.hpp <https://reviews.apache.org/r/10179/#comment38836> Seems like wrapping at the ( would have sufficed. src/slave/gc.hpp <https://reviews.apache.org/r/10179/#comment38837> Why are these together? I thought we placed all variables below functions? src/tests/gc_tests.cpp <https://reviews.apache.org/r/10179/#comment38839> Should there be a TODO on these to be using a non-clock settle? - Ben Mahler On March 28, 2013, 10:06 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10179/ > ----------------------------------------------------------- > > (Updated March 28, 2013, 10:06 p.m.) > > > Review request for mesos, Vinod Kone and Ben Mahler. > > > Description > ------- > > It probably makes sense to create tickets to replace existing sleep calls in > other tests to use EXPECT_DISPATCH. > > > Diffs > ----- > > src/slave/gc.hpp c5cceb13b907c222fc177f1bdeeb838ba8efcc4e > src/slave/gc.cpp 92ea79c126f0852a9aeaacd51e7261962f56b8d1 > src/tests/environment.cpp fd618787916a3d88eecf72c51a755b05c79eef59 > src/tests/gc_tests.cpp 67bf957c2ed61daefcd3baf2ee7aa4abaa524eab > > Diff: https://reviews.apache.org/r/10179/diff/ > > > Testing > ------- > > # Check it: > ./bin/mesos-tests.sh --gtest_filter=Garbage* --gtest_repeat=1000 > --gtest_shuffle > > > Thanks, > > Benjamin Hindman > >
