-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10243/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Description
-------
There were a few general nondeterministic bugs in the allocator tests that have
been cleaned up:
- The number of times that resourcesChanged is called on an executor is not a
hard guarantee, and we don't care for the purposes of these tests anyways, so
they are now all WillRepeatedly(DoDefault()).
- shutdown is occasionally not called on the executor (because the test has
already exited or the isolator took too long to send the shutdown message and
the slave just killed the executor), and again we don't care for the purpose of
these tests, so these are all now Times(AtMost(1)).
- frameworkRemoved was sometimes not being called on the allocator before the
test ended, so since we do care about these calls they now all have triggers.
This addresses bug MESOS-410.
https://issues.apache.org/jira/browse/MESOS-410
Diffs
-----
src/tests/allocator_tests.cpp 04a8581
src/tests/allocator_zookeeper_tests.cpp cc6e22e
Diff: https://reviews.apache.org/r/10243/diff/
Testing
-------
On both OSX 10.8.3 and Ubuntu 12.04 Server:
bin/mesos-tests.sh --gtest_filter=*Allocator* --gtest_repeat=500
--gtest_break_on_failure
Thanks,
Thomas Marshall
