-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10244/#review18626
-----------------------------------------------------------



src/deploy/mesos-start-masters.sh.in
<https://reviews.apache.org/r/10244/#comment39022>

    I'm a bit confused on what lines you want to ignore.
    
    For e.g: if a masters file looks as follows:
    
    # My ip1
    ip1
    ip2 # My ip2
    
    Looks like you are trying to only select ip1? Is this true? If yes, why not 
just do 'grep -v "#"' ?
    


- Vinod Kone


On April 3, 2013, 2 a.m., Andrew Ash wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10244/
> -----------------------------------------------------------
> 
> (Updated April 3, 2013, 2 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Description
> -------
> 
> Ignore commented lines in slaves/masters files
> 
> Commented-out lines are those that are prefixed with a hash '#'
> 
> 
> Diffs
> -----
> 
>   src/deploy/mesos-start-masters.sh.in 
> d9833c39b0c6e9b8e9e1b9757a7486d852688643 
>   src/deploy/mesos-start-slaves.sh.in 
> 4f33babc7d72119b7bf10d394f5982c65360fc8b 
>   src/deploy/mesos-stop-masters.sh.in 
> 6800c19bccc4b93b4294b929328495b26d0f4ca0 
>   src/deploy/mesos-stop-slaves.sh.in e622eb0e9a23c7c095ccfa4da790c0f2cc8f7fc5 
> 
> Diff: https://reviews.apache.org/r/10244/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Ash
> 
>

Reply via email to