----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10278/#review18725 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/10278/#comment39140> You're calling get() without the Option having a value? This looks like it will fail the assertion in Option::get. src/slave/slave.cpp <https://reviews.apache.org/r/10278/#comment39141> What is the TODO to fix this "hack"? I'm missing the context so I don't see why we have to do this change? Can you elaborate in the review description? - Ben Mahler On April 4, 2013, 1:20 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10278/ > ----------------------------------------------------------- > > (Updated April 4, 2013, 1:20 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa > > Diff: https://reviews.apache.org/r/10278/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
