Did you forget to update?
On Mon, Mar 25, 2013 at 7:12 PM, Benjamin Hindman <[email protected]> wrote: > > > > On March 25, 2013, 4:07 a.m., Vinod Kone wrote: > > > src/slave/slave.hpp, line 705 > > > < > https://reviews.apache.org/r/10111/diff/1/?file=274256#file274256line705> > > > > > > Forked pid is checkpointed before libprocess pid. > > > > > > When recovering in unsafe mode, the assumption is that the slave > can die after checkpointing forked pid but before libprocess pid. So, it is > not possible for libprocess pid to exist but not forked pid. If so, it is a > really bad situation (file corruption). > > Added a comment. > > > - Benjamin > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10111/#review18336 > ----------------------------------------------------------- > > > On March 25, 2013, 1:47 a.m., Benjamin Hindman wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/10111/ > > ----------------------------------------------------------- > > > > (Updated March 25, 2013, 1:47 a.m.) > > > > > > Review request for mesos and Vinod Kone. > > > > > > Description > > ------- > > > > This is work in progress. > > > > > > Diffs > > ----- > > > > src/slave/cgroups_isolator.hpp 1732c4e9ea44eb3b4d6234898f28bf3a02df4a7e > > src/slave/cgroups_isolator.cpp ebc2843c57d5c1787394d0572aca1ead3e5734f1 > > src/slave/http.cpp 260df43a9fdffe969533f4f2efd37cdcfe0fcb35 > > src/slave/isolator.hpp d702041784f5db159efd7da4d916405e86d99741 > > src/slave/process_isolator.hpp 920a667bb2ecc4c497ada39020579012110d9204 > > src/slave/process_isolator.cpp 210ea10ad97e08c7a303249da97e70b438dfe11d > > src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 > > src/slave/slave.cpp 091ec5ed19924aef31b761e68b70b8d042f9a9b7 > > > > Diff: https://reviews.apache.org/r/10111/diff/ > > > > > > Testing > > ------- > > > > make > > > > > > Thanks, > > > > Benjamin Hindman > > > > > >
