> On April 5, 2013, 7:38 p.m., Ben Mahler wrote: > > src/examples/balloon_executor.cpp, line 24 > > <https://reviews.apache.org/r/10241/diff/1/?file=277220#file277220line24> > > > > In all of these removed includes, how did you check whether sleep() was > > the only call used from unistd.h?
The tests ran successful. Is this sufficient? - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10241/#review18729 ----------------------------------------------------------- On April 2, 2013, 10:55 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10241/ > ----------------------------------------------------------- > > (Updated April 2, 2013, 10:55 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > This is the part 2. > Part 1: https://reviews.apache.org/r/10231/ > > > This addresses bug MESOS-415. > https://issues.apache.org/jira/browse/MESOS-415 > > > Diffs > ----- > > src/examples/balloon_executor.cpp 6d0d0f99310626978c526ff5eb0778c2bf84587b > src/examples/long_lived_executor.cpp > 3b4a6867ed1a64571edbc606aeec3b3271b05fb9 > src/examples/test_executor.cpp f06dbb30d5f178d2cce274f1ac79763b1db54721 > src/exec/exec.cpp 3d6d712c9577a7b95646e3ca49a7d8bfe47716fd > src/launcher/executor.cpp 9e0377fba4257fc5579b645c175bc6f0b565fc66 > src/log/log.cpp 852ad119e4f36ad1fd56555af27e440066e9f294 > src/tests/allocator_tests.cpp 04a85815362eaff21027ea7894ee06042fb80dc2 > src/tests/master_tests.cpp c74cb5e05dc068dc75c31fb85e03c71adf4d5ce9 > src/tests/process_spawn.cpp d6996a218763db1f2def48fa0422518b75f47590 > src/tests/slave_recovery_tests.cpp b4276edd09282640fa167cc70d1ab2b1deab3225 > src/tests/status_update_manager_tests.cpp > a355ecd09a0462e701707862ceb62584826a4e5e > src/tests/utils.hpp 32784a79804ecb8758fb9ae6cdb4bb1e87c29252 > src/tests/zookeeper_tests.cpp ac3c39cc9d79dc588eff855c69771ff26902b2ef > third_party/libprocess/src/process.cpp > b4f27077f70468276b9a2f2cbce26036449b5b96 > third_party/libprocess/src/tests/process_tests.cpp > f49cabc91257e8cc72a45804a2ddbc28b4e06992 > > Diff: https://reviews.apache.org/r/10241/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jiang Yan Xu > >
