----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9997/#review19035 -----------------------------------------------------------
Ship it! src/slave/slave.hpp <https://reviews.apache.org/r/9997/#comment39557> Put a comment about internal class. src/slave/slave.hpp <https://reviews.apache.org/r/9997/#comment39558> ditto src/slave/slave.cpp <https://reviews.apache.org/r/9997/#comment39559> s/file/entry src/slave/slave.cpp <https://reviews.apache.org/r/9997/#comment39560> skip files. and move path down. src/tests/gc_tests.cpp <https://reviews.apache.org/r/9997/#comment39562> latest abstractions - Vinod Kone On April 9, 2013, 8:59 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9997/ > ----------------------------------------------------------- > > (Updated April 9, 2013, 8:59 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 > src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa > src/slave/state.cpp e5c32257978d8407535e05ed73f8a50bdc2f651d > src/slave/status_update_manager.hpp > e6ca40c5c05c0952cf76fb1db7eff2e4270c0d24 > src/slave/status_update_manager.cpp > 044d245f370ef23ddc67fadbf7f8fe9d75dd662a > src/tests/gc_tests.cpp 8c2e6e137748b9c8fa3db826752bed6a03c6c92f > src/tests/slave_recovery_tests.cpp d0ff9b73e06e89a5409f038be2766333e0a0689e > > Diff: https://reviews.apache.org/r/9997/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
