----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10460/#review19155 -----------------------------------------------------------
third_party/libprocess/include/process/gtest.hpp <https://reviews.apache.org/r/10460/#comment39733> I know I called this AWAIT_READY. But looking at how you renamed things, I would prefer ASSERT_READY() This tells me you are doing an assert. That way you can also have EXPECT_READY(), which you are missing. third_party/libprocess/include/process/gtest.hpp <https://reviews.apache.org/r/10460/#comment39734> ditto. s/AWAIT_FAILED/ASSERT_FAILED third_party/libprocess/include/process/gtest.hpp <https://reviews.apache.org/r/10460/#comment39735> ditto third_party/libprocess/src/tests/process_tests.cpp <https://reviews.apache.org/r/10460/#comment39732> How about just EXPECT_READY? third_party/libprocess/src/tests/statistics_tests.cpp <https://reviews.apache.org/r/10460/#comment39731> I think these read better as ASSERT_READY()? Why AWAIT_ASSERT_READY? - Vinod Kone On April 15, 2013, 2:28 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10460/ > ----------------------------------------------------------- > > (Updated April 15, 2013, 2:28 a.m.) > > > Review request for mesos, Vinod Kone and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > third_party/libprocess/include/process/gtest.hpp > 80d5194489bc8f5d4897a075e655d543480e314e > third_party/libprocess/src/tests/io_tests.cpp > 9115a968b81739c33afe98b673797ca472cc8b87 > third_party/libprocess/src/tests/process_tests.cpp > 562f52c6833183e6e4e81f6ae307cf28e40404b3 > third_party/libprocess/src/tests/statistics_tests.cpp > 6efcc8004fc637e5c4dc8f0ba0e34c0a06a8c052 > > Diff: https://reviews.apache.org/r/10460/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
