----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10461/#review19156 -----------------------------------------------------------
Ship it! src/tests/files_tests.cpp <https://reviews.apache.org/r/10461/#comment39736> Per my previous review's comments, this could be simply called EXPECT_READY and EXPECT_FAILED - Vinod Kone On April 15, 2013, 2:28 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10461/ > ----------------------------------------------------------- > > (Updated April 15, 2013, 2:28 a.m.) > > > Review request for mesos, Vinod Kone and Ben Mahler. > > > Description > ------- > > > Diffs > ----- > > src/tests/allocator_tests.cpp 85a49818d1d2990c98601cc44c6fbdfa1c0cba1f > src/tests/allocator_zookeeper_tests.cpp > 82a498e40bd9a362c2e2aefb7bf0d634be31bfcd > src/tests/cgroups_tests.cpp 34ae0d28ec89dc05d9a218eeec5f4e674fbc1ae8 > src/tests/exception_tests.cpp 1c9b8f0f144cd310bcfa54ee1c71c539921a30ed > src/tests/files_tests.cpp dbb4d26a3082d083950b5f371a132628912f6c04 > src/tests/gc_tests.cpp 1330a72534b2175e049aaa092af99a6e1160157d > src/tests/logging_tests.cpp 67a94b0f397090323fd9cb05b9af9ddf8e3cdb99 > src/tests/master_detector_tests.cpp > 980f3c720301b83af668e10f479adb9cce4f0c9f > src/tests/master_tests.cpp f359e333ff2fbb8d189f8e30a65cb8b05f13b74e > src/tests/monitor_tests.cpp eb5bb73ce96ac11b76dc288834087c06964343fe > src/tests/resource_offers_tests.cpp > ad3640f759e0771d2d393623893a1bf5e8d60349 > src/tests/state_tests.cpp 1b3acf78fab4b9bb4c804698c8354c8d0f60cbcb > src/tests/status_update_manager_tests.cpp > 23ba5a10200f6c9ff677bdaa760c764581c3c63b > src/tests/utils.hpp b5c577ddc3d4296fe8e77815cad158e2ef3bbbda > src/tests/zookeeper_tests.cpp 37e1b77a9c728034936eddd451c75a46605885db > > Diff: https://reviews.apache.org/r/10461/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
