----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10233/ -----------------------------------------------------------
(Updated April 17, 2013, 6:39 a.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Changes ------- comments and rebase. no need for review. Description ------- See summary. The main crux is two fold 1) Shutdown a slave after all executors have terminated 2) Delete the "latest" symlink under /path/to/meta/slaves/ to make sure a shutdown slave comes up as new slave when restarted. I had to refactor cleanup(), because turns out there are quite a few edge cases to guard against. Diffs (updated) ----- src/slave/process_isolator.cpp d8d940f069d596a1f0d14832270ca94d9f2b2314 src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa src/slave/state.cpp e5c32257978d8407535e05ed73f8a50bdc2f651d src/tests/slave_recovery_tests.cpp 7be332b74367869e2b4c847fea348535cc526a23 Diff: https://reviews.apache.org/r/10233/diff/ Testing ------- make check sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*ShutdownSlave*" --verbose --gtest_repeat=100 --gtest_break_on_failure Thanks, Vinod Kone
