> On April 17, 2013, 5:44 p.m., Ben Mahler wrote: > > Looks like the TUTORIAL.sh diff is messed up in this review. > > Brenden Matthews wrote: > I can't figure it out. Seems to be a problem with Review Board. Here's > the patch: > > > http://ompldr.org/vaTRycw/0008-Build-fix-for-HadoopPipes.cc-with-GCC-4.7.patch > > Ben Mahler wrote: > Why is there additional output at the top of the patch: > > From d15c769d925c36ca5ad39058ec9374f6858aad6e Mon Sep 17 00:00:00 2001 > From: Brenden Matthews <[email protected]> > Date: Tue, 16 Apr 2013 13:22:10 -0700 > Subject: [PATCH 08/11] Build fix for HadoopPipes.cc with GCC 4.7. > > --- > hadoop/HadoopPipes.cc.patch | 10 ++++++++++ > hadoop/Makefile.am | 3 +++ > hadoop/TUTORIAL.sh | 43 > +++++++++++++++++++++++++++++++++++++++++-- > 3 files changed, 54 insertions(+), 2 deletions(-) > create mode 100644 hadoop/HadoopPipes.cc.patch
That's the standard git patch format. The patch doesn't apply because Review Board doesn't seem to have the ability to use >1 parent patch. The patch depends on some of my previously submitted patches. - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10560/#review19333 ----------------------------------------------------------- On April 17, 2013, 11:18 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10560/ > ----------------------------------------------------------- > > (Updated April 17, 2013, 11:18 p.m.) > > > Review request for mesos. > > > Description > ------- > > Build fix for HadoopPipes.cc with GCC 4.7. > > > Diffs > ----- > > hadoop/HadoopPipes.cc.patch PRE-CREATION > hadoop/Makefile.am ceac085 > hadoop/TUTORIAL.sh f8131cd > > Diff: https://reviews.apache.org/r/10560/diff/ > > > Testing > ------- > > Used it production at Airbnb. > > > Thanks, > > Brenden Matthews > >
