> On April 17, 2013, 5:51 p.m., Ben Mahler wrote: > >
Do you see CMake making these sorts of things easier? > On April 17, 2013, 5:51 p.m., Ben Mahler wrote: > > configure.ac, line 367 > > <https://reviews.apache.org/r/10562/diff/1/?file=281695#file281695line367> > > > > What is python-config? > > Brenden Matthews wrote: > It's part of the Python distribution: > > https://github.com/python-git/python/blob/master/Misc/python-config.in > > It's just a script that can be used to test the current python > installation. Ah I see, I have a linux machine here that doesn't know where it is: $ python-config -bash: python-config: command not found With the default python being 2.4.3, was python-config not introduced at that point? It has the following on its path: $ python<TAB><TAB> python python2 python2.4 python26 python2.6 python2.6-config python2.7 > On April 17, 2013, 5:51 p.m., Ben Mahler wrote: > > configure.ac, line 366 > > <https://reviews.apache.org/r/10562/diff/1/?file=281695#file281695line366> > > > > I'm confused, can you comment as to what you're checking here? > > Brenden Matthews wrote: > It's just a simple check to ensure there is a development version of > Python installed. The build fails otherwise if you don't have the Python dev > libraries installed. It should fail at configure time rather than compile > time. Got it, can we use an existing macro? http://www.gnu.org/software/autoconf-archive/ax_python.html - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10562/#review19335 ----------------------------------------------------------- On April 16, 2013, 10:07 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10562/ > ----------------------------------------------------------- > > (Updated April 16, 2013, 10:07 p.m.) > > > Review request for mesos. > > > Description > ------- > > Check for Python.h in configure script. > > > Diffs > ----- > > configure.ac c3b5a05 > > Diff: https://reviews.apache.org/r/10562/diff/ > > > Testing > ------- > > Used in production at Airbnb. > > > Thanks, > > Brenden Matthews > >
