> On April 23, 2013, 7:36 p.m., Vinod Kone wrote: > > third_party/libprocess/include/process/process.hpp, lines 331-335 > > <https://reviews.apache.org/r/10733/diff/1/?file=283414#file283414line331> > > > > This seems like a potentially risky function to be exposed to users. > > Now users can masquerade as a different sender than themselves. Do we want > > to allow this? > > > > Presumably you need this in your test? So, I would be ok if we can > > somehow only expose this to test writers and not anyone else. > > > > Thoughts?
Hm.. so the existing process::post allow one to send anonymous messages, that is, from no sender. I could hide this in a 'testing' namespace.. or place it inside the gtest header..? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10733/#review19595 ----------------------------------------------------------- On April 23, 2013, 5:42 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10733/ > ----------------------------------------------------------- > > (Updated April 23, 2013, 5:42 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See above. > > > Diffs > ----- > > third_party/libprocess/include/process/process.hpp > 513431481a1c9d4f445958960cd001f2d1bb1c81 > third_party/libprocess/include/process/protobuf.hpp > 580c87a491417d735416f2b9f2cbc25564b6edc7 > third_party/libprocess/src/process.cpp > 0a57e8000c3cb9e37aacb485b78a58ba32c7c0ed > > Diff: https://reviews.apache.org/r/10733/diff/ > > > Testing > ------- > > make check, also used this explicitly in my next change > > > Thanks, > > Ben Mahler > >
