> On April 26, 2013, 6:15 p.m., Ben Mahler wrote: > > src/master/master.cpp, line 1052 > > <https://reviews.apache.org/r/10724/diff/2/?file=284938#file284938line1052> > > > > Well.. this is only a likely cause, right?
well the task might be lost while the slave was down before it tries to even perform recovery or re-registration. do you have a better message in mind? > On April 26, 2013, 6:15 p.m., Ben Mahler wrote: > > src/tests/fault_tolerance_tests.cpp, line 974 > > <https://reviews.apache.org/r/10724/diff/2/?file=284939#file284939line974> > > > > I hope you'll come back for this! ;) I will use your abstraction when you commit it and fix this test, i promise :) - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10724/#review19787 ----------------------------------------------------------- On April 26, 2013, 5:59 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10724/ > ----------------------------------------------------------- > > (Updated April 26, 2013, 5:59 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08 > src/master/master.cpp c3b26b136a529eee34e9cdf9700176c232f6e436 > src/tests/fault_tolerance_tests.cpp > 0348f20a8f4333f7d2f3786c33e55713cbcbcbe0 > src/tests/slave_recovery_tests.cpp d0c72738ca6fcc0ccf7233efe0ae7ab243fa1f4b > > Diff: https://reviews.apache.org/r/10724/diff/ > > > Testing > ------- > > make check > > sudo GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="*ConsolidateTasksOnSlaveReregistration*" --verbose > --gtest_repeat=1000 --gtest_break_on_failure > > > Thanks, > > Vinod Kone > >
