> On April 23, 2013, 6:57 p.m., Ben Mahler wrote: > > Why? > > Vinod Kone wrote: > because slave id could be optional in a status update and it could be > useful to generate a status update when slave id is unknown. i thought i > would need it in my subsequent review, but i guess i didn't come across the > case when i didn't know the slave id.
Can this be discarded then? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10723/#review19591 ----------------------------------------------------------- On April 26, 2013, 6:27 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10723/ > ----------------------------------------------------------- > > (Updated April 26, 2013, 6:27 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/common/protobuf_utils.hpp 85d9ba7150a443a9b3170cdee74777a28270cd2b > src/slave/slave.cpp a0d3864d3e02c7889646f9ff004dad82f67d263b > src/tests/fault_tolerance_tests.cpp > d3476f7f5d1b7e2ed45385f5145eaccd6c114d21 > > Diff: https://reviews.apache.org/r/10723/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
