----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10814/#review19834 -----------------------------------------------------------
Ship it! src/common/resources.hpp <https://reviews.apache.org/r/10814/#comment40908> use None() src/common/resources.hpp <https://reviews.apache.org/r/10814/#comment40909> None() src/slave/constants.cpp <https://reviews.apache.org/r/10814/#comment40910> Gigabytes(1) src/tests/resources_tests.cpp <https://reviews.apache.org/r/10814/#comment40911> Would be nice to change the memory strings to use the size suffixes, Bytes will already parse it! :) e.g. mem:1024MB - Ben Mahler On April 27, 2013, 2:52 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10814/ > ----------------------------------------------------------- > > (Updated April 27, 2013, 2:52 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary > > > Diffs > ----- > > src/common/resources.hpp e15c2d209b877f1f2cf757bfc1b055c5148cb080 > src/slave/constants.hpp ca1124afff9ef989c05723e314ea40555303a8ff > src/slave/constants.cpp 6cd97f97659d68297829c67a7513a193214c9a4a > src/slave/slave.hpp f9d9c2b32983700fb09b266a0abf2a396174ae05 > src/slave/slave.cpp 86a15fce93e6aa3f7a8f9700ef2dcea26fda0d87 > src/tests/resources_tests.cpp 684379f60e9af2dd4a4c75c1f121e253c4c13270 > > Diff: https://reviews.apache.org/r/10814/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
