----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10809/#review19869 -----------------------------------------------------------
third_party/libprocess/third_party/stout/Makefile.am <https://reviews.apache.org/r/10809/#comment40968> Hmm, I'm not sure this is what you want. We ALWAYS want to include these files in the distribution, we just don't want to build them if we're not on Linux ... third_party/libprocess/third_party/stout/configure.ac <https://reviews.apache.org/r/10809/#comment40985> Don't want to derail this review, but is there a clean way to just use target_os in Makefile.am? third_party/libprocess/third_party/stout/include/stout/proc.hpp <https://reviews.apache.org/r/10809/#comment40988> s|proc|stout/proc| s/linux systems/Linux/ - Benjamin Hindman On April 27, 2013, 12:54 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10809/ > ----------------------------------------------------------- > > (Updated April 27, 2013, 12:54 a.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Jiang Yan Xu. > > > Description > ------- > > Part 1 of moving src/linux/proc.{cpp,hpp} into stout. > > This was a copy from src/linux/proc.{cpp,hpp}. > > > Diffs > ----- > > third_party/libprocess/third_party/stout/Makefile.am > 2f5116f263bde00a5a324fbb3403b5b7514b1a1a > third_party/libprocess/third_party/stout/configure.ac > 86e1ff369bdcf1056bf2ce7606aa3c910e699173 > third_party/libprocess/third_party/stout/include/stout/os.hpp > 4d51693504f15236c131600737d0b6ddb6a1a819 > third_party/libprocess/third_party/stout/include/stout/proc.hpp > 19000eb182cef4ecbf10fc3aa6c6e6c076f1ac46 > third_party/libprocess/third_party/stout/tests/proc_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/10809/diff/ > > > Testing > ------- > > OSX and Linux: make check > > > Thanks, > > Ben Mahler > >
