> On April 29, 2013, 11 p.m., Benjamin Hindman wrote: > > src/master/master.cpp, line 1031 > > <https://reviews.apache.org/r/10734/diff/3/?file=284531#file284531line1031> > > > > This check seems very redundant.
This checks that the maps are kept in sync, that is, slaves and deactivatedSlaves are disjoint. I'd like to keep this until we move this into the registrar you've been working on. Sound good? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10734/#review19911 ----------------------------------------------------------- On April 25, 2013, 9:38 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10734/ > ----------------------------------------------------------- > > (Updated April 25, 2013, 9:38 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See MESOS-446. > > > This addresses bug MESOS-446. > https://issues.apache.org/jira/browse/MESOS-446 > > > Diffs > ----- > > src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08 > src/master/master.cpp c3b26b136a529eee34e9cdf9700176c232f6e436 > src/tests/fault_tolerance_tests.cpp > d3476f7f5d1b7e2ed45385f5145eaccd6c114d21 > > Diff: https://reviews.apache.org/r/10734/diff/ > > > Testing > ------- > > Added a test. > > > Thanks, > > Ben Mahler > >
