> On April 25, 2013, 7:41 p.m., Vinod Kone wrote: > >
Can I get a ship it here? > On April 25, 2013, 7:41 p.m., Vinod Kone wrote: > > src/tests/monitor_tests.cpp, line 79 > > <https://reviews.apache.org/r/10715/diff/1/?file=283274#file283274line79> > > > > Why does this need to be set? > > Ben Mahler wrote: > It is a required field. It is also what the monitor uses as the timestamp > for the Statistics module. Ping. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10715/#review19719 ----------------------------------------------------------- On April 23, 2013, 12:30 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10715/ > ----------------------------------------------------------- > > (Updated April 23, 2013, 12:30 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > Discovered this while working on the statistics "sparsification" changes. > > > This addresses bug MESOS-399. > https://issues.apache.org/jira/browse/MESOS-399 > > > Diffs > ----- > > src/tests/monitor_tests.cpp 471dc73dc6188904fdfa83ef8a34a90d63ef88d3 > > Diff: https://reviews.apache.org/r/10715/diff/ > > > Testing > ------- > > ./bin/mesos-tests.sh --gtest_filter="*WatchUnwatch*" --gtest_break_on_failure > --gtest_repeat=1000 --verbose > > > Thanks, > > Ben Mahler > >
