----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10808/#review19961 -----------------------------------------------------------
High level review. src/linux/cgroups.hpp <https://reviews.apache.org/r/10808/#comment41177> Hm.. I'm not sure I like this new API call. My understanding was that subsystems are "attached" to hierarchies, rather than cgroups. The comment on SubsystemInfo.cgroups is: int cgroups; // Number of cgroups for the subsystem. Could you not get the hierarch(y|ies) with the subsystem(s) mounted using cgroups::hierarchy(subsystems), then count the cgroups with cgroups::get(hierarchy)? src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/10808/#comment41178> I wish there was a simpler way to do this. Do you think this is a kernel bug? (Note that we haven't encountered this on CentOS). If so, and it occurs on kernels we want to support, is this only an issue during the tests, or could there be issues in a production environment? - Ben Mahler On April 26, 2013, 10:47 p.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10808/ > ----------------------------------------------------------- > > (Updated April 26, 2013, 10:47 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > Previously, our the CgroupsAnyHierarchy*Tests were not waiting long enough > for the cgroups created to be cleaned up before the test finished, resulting > in failures when the next test was unable to create cgroups for itself. This > patch attempts to fix that by having CgroupsAnyHierarchy::TearDown wait until > the number of cgroups each subsystem is attached to, documented in > /proc/cgroups, is the same as it was before the test ran. > > > This addresses bug MESOS-449. > https://issues.apache.org/jira/browse/MESOS-449 > > > Diffs > ----- > > src/linux/cgroups.hpp 3e86828 > src/linux/cgroups.cpp 139c3ef > src/tests/cgroups_tests.cpp 3734315 > > Diff: https://reviews.apache.org/r/10808/diff/ > > > Testing > ------- > > On both Ubuntu and CentOS, on both clean installs and in the presence of > pre-existing cgroups on the system (such as those left behind by > BalloonFramework failing): > > bin/mesos-tests.sh --gtest_break_on_failure --gtest_repeat=1000 > --gtest_filter=*CgroupsAny* > > > Thanks, > > Thomas Marshall > >
