> On April 30, 2013, 5:35 p.m., Ben Mahler wrote: > > src/tests/reaper_tests.cpp, line 181 > > <https://reviews.apache.org/r/10746/diff/4/?file=286030#file286030line181> > > > > Don't forget this one! ;) > > > > s/stat/status_/ > > > > We try to avoid abbreviations.
This is addressed in (a later review) https://reviews.apache.org/r/10747/ Well, because BenH's comment is in that review. I could have changed it here and then I would go there to say "Fixed in https://reviews.apache.org/r/10746/";. I think the latter is more preferable (fix it when it first appears), right? It'll be that way next time. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10746/#review19962 ----------------------------------------------------------- On April 30, 2013, 1:21 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10746/ > ----------------------------------------------------------- > > (Updated April 30, 2013, 1:21 a.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > - Previously the listener was notified when its child processes terminate > whether it register them or not. > > > Diffs > ----- > > src/slave/cgroups_isolator.hpp f8fabc4e1c3c303b35a76db96b4b2479bd7c8ff8 > src/slave/cgroups_isolator.cpp 8b79da50d8fb0c2c8716dd7d2c734b65c32f60b4 > src/slave/process_isolator.hpp 9875f4a6e8e109e31ad390fbd7a84d03ad747190 > src/slave/process_isolator.cpp 6e2af87d291d7c3448393c1ffa816f7020e2dff6 > src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90 > src/slave/reaper.cpp bd3dcef07c370ad338b478755bf8f7ce6408e4a3 > src/tests/reaper_tests.cpp 0809c1ff17eb949beb1bdd922fdced022aa202f3 > src/tests/utils.hpp ca3ecd7f0cab283327bf83e57d4b405b4ada9c74 > > Diff: https://reviews.apache.org/r/10746/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
