> On May 2, 2013, 1:24 a.m., Ben Mahler wrote: > > third_party/libprocess/include/process/limiter.hpp, line 29 > > <https://reviews.apache.org/r/10891/diff/1/?file=286794#file286794line29> > > > > Document?
done > On May 2, 2013, 1:24 a.m., Ben Mahler wrote: > > third_party/libprocess/include/process/limiter.hpp, line 26 > > <https://reviews.apache.org/r/10891/diff/1/?file=286794#file286794line26> > > > > Document the constructor, to be explicit about 'permits' and 'duration'. This is already documented at the top of the class. Were you looking for more? > On May 2, 2013, 1:24 a.m., Ben Mahler wrote: > > third_party/libprocess/include/process/limiter.hpp, line 103 > > <https://reviews.apache.org/r/10891/diff/1/?file=286794#file286794line103> > > > > deque is implying we want the properties of a deque.. isn't queue > > sufficient? (I know the default container for a queue is a deque, but I > > think it makes it clearer). i'm assuming because there is no easy way to empty a queue. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10891/#review20043 ----------------------------------------------------------- On May 2, 2013, 7:18 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10891/ > ----------------------------------------------------------- > > (Updated May 2, 2013, 7:18 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > BenH's patch. > > > Diffs > ----- > > third_party/libprocess/Makefile.am d9d9110cc75d71642e621097bbc8bdcb88fdc0f8 > third_party/libprocess/include/process/limiter.hpp PRE-CREATION > third_party/libprocess/src/tests/process_tests.cpp > 8fbf19676c54eb0da6f8daa042de127608bcb00b > > Diff: https://reviews.apache.org/r/10891/diff/ > > > Testing > ------- > > sudo ./third_party/libprocess/tests --gtest_filter="*limiter*" --verbose > --gtest_repeat=1000 --gtest_break_on_failure > > > Thanks, > > Vinod Kone > >
