> On May 3, 2013, 8:46 p.m., Vinod Kone wrote: > > src/master/master.cpp, lines 1266-1271 > > <https://reviews.apache.org/r/10927/diff/1/?file=287636#file287636line1266> > > > > Its interesting to see that you wanted to shuffle the offers here. > > > > While I don't have an objection per se, can't this be done by the > > frameworks themselves? I feel like each framework could/should decide how > > they want to use (random, rack diversity, etc) the offers that were given > > to it.
Yeah, I thought about that as well. I decided this was the path of least resistance. If the frameworks want to select offers according to different ordering, that's fine. The problem is that most (all?) of the frameworks (at least, the ones I use) select the offers in the order they're received. Rather than rewriting all these framework schedulers, it makes sense to just shuffle the offers before sending them. - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10927/#review20146 ----------------------------------------------------------- On May 3, 2013, 6:46 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10927/ > ----------------------------------------------------------- > > (Updated May 3, 2013, 6:46 p.m.) > > > Review request for mesos. > > > Description > ------- > > From 7666cbd4de6dfc49a162925ed2644d65d57eab87 Mon Sep 17 00:00:00 2001 > From: Brenden Matthews <[email protected]> > Date: Sat, 27 Apr 2013 09:58:46 -0700 > Subject: [PATCH 4/9] Shuffle offers before sending to frameworks. > > This helps ensure fair allocation of resources. > --- > src/master/master.cpp | 8 ++++++++ > 1 file changed, 8 insertions(+) > > > Diffs > ----- > > src/master/master.cpp 3207157 > > Diff: https://reviews.apache.org/r/10927/diff/ > > > Testing > ------- > > Used in production at airbnb. > > > Thanks, > > Brenden Matthews > >
