> On May 3, 2013, 8:40 p.m., Vinod Kone wrote: > > can't open the patch again :( > > Brenden Matthews wrote: > I still don't understand review board. > > Here are all of the patches: > > http://ompldr.org/vaWIzYw/patches.tar.bz2 > > Here's that specific patch: > > > http://ompldr.org/vaWIzZA/0011-Hadoop-tutorial-version-bump-CDH4.2.0-4.2.1.patch > > Ben Mahler wrote: > Any way you can fix the ReviewBoard diffs on this? We'd love to get this > change :) > > Brenden Matthews wrote: > I don't know how to fix it. The patch depends on >1 previous patches, > and review board only permits adding 1 parent patch. > > When I submitted one patch with multiple changes, I was asked to split > the changes into multiple patches. I can't do both.
Ah, this is what we use support/post-reviews.py for, which allows you to send a chain of reviews based on the commits in your current branch. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10926/#review20145 ----------------------------------------------------------- On May 3, 2013, 6:45 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10926/ > ----------------------------------------------------------- > > (Updated May 3, 2013, 6:45 p.m.) > > > Review request for mesos. > > > Description > ------- > > From 5e1961bc57316d128663bd964512c549d94088a9 Mon Sep 17 00:00:00 2001 > From: Brenden Matthews <[email protected]> > Date: Fri, 26 Apr 2013 15:36:54 -0700 > Subject: [PATCH 3/9] Hadoop tutorial version bump (CDH4.2.0 -> 4.2.1). > > --- > hadoop/HadoopPipes.cc.patch | 4 ++-- > hadoop/Makefile.am | 24 > ++++++++++---------- > hadoop/TUTORIAL.sh | 12 +++++----- > .../hadoop-2.0.0-mr1-cdh4.2.0_hadoop-env.sh.patch | 14 ------------ > hadoop/hadoop-2.0.0-mr1-cdh4.2.0_mesos.patch | 22 ------------------ > .../hadoop-2.0.0-mr1-cdh4.2.1_hadoop-env.sh.patch | 14 ++++++++++++ > hadoop/hadoop-2.0.0-mr1-cdh4.2.1_mesos.patch | 22 ++++++++++++++++++ > 7 files changed, 56 insertions(+), 56 deletions(-) > delete mode 100644 hadoop/hadoop-2.0.0-mr1-cdh4.2.0_hadoop-env.sh.patch > delete mode 100644 hadoop/hadoop-2.0.0-mr1-cdh4.2.0_mesos.patch > create mode 100644 hadoop/hadoop-2.0.0-mr1-cdh4.2.1_hadoop-env.sh.patch > create mode 100644 hadoop/hadoop-2.0.0-mr1-cdh4.2.1_mesos.patch > > > Diffs > ----- > > hadoop/HadoopPipes.cc.patch aa5df7c > hadoop/Makefile.am f32f268 > hadoop/TUTORIAL.sh d81c555 > hadoop/hadoop-2.0.0-mr1-cdh4.2.0_hadoop-env.sh.patch b915b1d > hadoop/hadoop-2.0.0-mr1-cdh4.2.0_mesos.patch 8a39444 > hadoop/hadoop-2.0.0-mr1-cdh4.2.1_hadoop-env.sh.patch PRE-CREATION > hadoop/hadoop-2.0.0-mr1-cdh4.2.1_mesos.patch PRE-CREATION > > Diff: https://reviews.apache.org/r/10926/diff/ > > > Testing > ------- > > Used in production at airbnb. > > > Thanks, > > Brenden Matthews > >
