> On May 8, 2013, 5:54 p.m., Benjamin Hindman wrote: > >
Will be discarding and sending out a separate chain for this due to the restructuring. > On May 8, 2013, 5:54 p.m., Benjamin Hindman wrote: > > third_party/libprocess/third_party/stout/include/stout/os/osx.hpp, line 52 > > <https://reviews.apache.org/r/10897/diff/1/?file=286974#file286974line52> > > > > Maybe this should not be internal but be provided for both Linux and > > OSX. Then see my comment below about children. Fixed in a subsequent review on this chain to do the refactor. > On May 8, 2013, 5:54 p.m., Benjamin Hindman wrote: > > third_party/libprocess/third_party/stout/include/stout/os/osx.hpp, line 150 > > <https://reviews.apache.org/r/10897/diff/1/?file=286974#file286974line150> > > > > Can children be implemented for Linux in terms of the new Process > > struct too? If so, can we have a single os::children call? Ditto. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10897/#review20330 ----------------------------------------------------------- On May 2, 2013, 1:40 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10897/ > ----------------------------------------------------------- > > (Updated May 2, 2013, 1:40 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See above. > > > Diffs > ----- > > third_party/libprocess/third_party/stout/include/stout/os/osx.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/10897/diff/ > > > Testing > ------- > > make check on OSX and Linux. > > > Thanks, > > Ben Mahler > >
