----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11056/#review20431 -----------------------------------------------------------
Ship it! third_party/libprocess/third_party/stout/include/stout/os.hpp <https://reviews.apache.org/r/11056/#comment42097> I'd prefer calling this 'mv' instead of 'rename' even though we are using the 'rename' syscall. Any reason not to do that? - Benjamin Hindman On May 10, 2013, 7:17 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11056/ > ----------------------------------------------------------- > > (Updated May 10, 2013, 7:17 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > third_party/libprocess/third_party/stout/include/stout/os.hpp > c71ae9ed32af2a14dc7b9b34521cb5ea6025235c > third_party/libprocess/third_party/stout/tests/os_tests.cpp > 047778d05ebbbefd85e4a163dbb6ab8445edfb7f > > Diff: https://reviews.apache.org/r/11056/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
