----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11162/#review20629 -----------------------------------------------------------
Ship it! thanks for updating this! much needed. docs/Mesos-c++-style-guide.md <https://reviews.apache.org/r/11162/#comment42523> i think you can revert this. the previous was clear. any reason you wanted to rephrase? docs/Mesos-c++-style-guide.md <https://reviews.apache.org/r/11162/#comment42520> "80 in code" doesn't really belong here. how about a section called "line wrapping"? for some inspiration on naming the sections you can take a look at eclipse's (C++ --> CodeStyle --> Formatter) docs/Mesos-c++-style-guide.md <https://reviews.apache.org/r/11162/#comment42521> Not just class definitions but all outer elements. for eg: class methods declared outside the class should still be separated by 2 lines. docs/Mesos-c++-style-guide.md <https://reviews.apache.org/r/11162/#comment42522> only if they are inside the class. - Vinod Kone On May 14, 2013, 6:14 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11162/ > ----------------------------------------------------------- > > (Updated May 14, 2013, 6:14 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/Mesos-c++-style-guide.md 98fe302ddc7ef1803450411f3a1a1d8f53b1329c > > Diff: https://reviews.apache.org/r/11162/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Jiang Yan Xu > >
