----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11129/#review20724 -----------------------------------------------------------
src/linux/cgroups.cpp <https://reviews.apache.org/r/11129/#comment42792> We generally avoid logging of statements that happen too frequently and are not much value outside debugging. How about converting this to VLOG(1) instead? This way you can start the slave with GLOG_v=1 in the env and get this if you are debugging something. Note that mesos also enables dynamically turning up logging by hitting a http endpoint on the slave. - Vinod Kone On May 14, 2013, 5:57 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11129/ > ----------------------------------------------------------- > > (Updated May 14, 2013, 5:57 p.m.) > > > Review request for mesos. > > > Description > ------- > > From 99b43f144b078f49c046b2a4dad0010c2e60a981 Mon Sep 17 00:00:00 2001 > From: Brenden Matthews <[email protected]> > Date: Fri, 10 May 2013 13:27:53 -0700 > Subject: [PATCH 22/24] More cgroup killTask() logging. > > Review: https://reviews.apache.org/r/11129 > --- > src/linux/cgroups.cpp | 2 ++ > 1 file changed, 2 insertions(+) > > > Diffs > ----- > > src/linux/cgroups.cpp cfdc3b2d9203920021fdd891265d3595baa670ff > > Diff: https://reviews.apache.org/r/11129/diff/ > > > Testing > ------- > > Used in production at airbnb. > > > Thanks, > > Brenden Matthews > >
