----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11268/ -----------------------------------------------------------
Review request for mesos and Vinod Kone. Description ------- It's possible we should move mkdtemp into MesosTest instead. The benefit will be that we can cleanup temporary directories in ~MesosTest() which would mean that less temporary directories leak when tests fail. I'll defer this for now. Diffs ----- src/tests/environment.hpp 61aa84debbf1ad31bc59be9bc91b6babef4881a3 src/tests/environment.cpp c94c85fc2f710dc2157f6b61edb7bfb0df21a579 src/tests/main.cpp e32ec0cac7b7ab9b31f4e419d0c1426b2c8aeb65 src/tests/script.cpp d7f103eb08335638bca57ccab77646534342b058 src/tests/utils.hpp ca3ecd7f0cab283327bf83e57d4b405b4ada9c74 src/tests/utils.cpp 9d1d5ad1e192b0f44a7a7173839b292f6bedad15 Diff: https://reviews.apache.org/r/11268/diff/ Testing ------- make check Thanks, Benjamin Hindman
