----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11202/#review20792 -----------------------------------------------------------
Ship it! Please split this up into libprocess, stout, and Mesos commits and we can ship this. Thank you! - Benjamin Hindman On May 20, 2013, 10:36 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11202/ > ----------------------------------------------------------- > > (Updated May 20, 2013, 10:36 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > - Fixed Duration's stream insertion operator so that the output string does > not have trailing zeros after the decimal point. (libstout) > - Changed Duration to 1) use int64_t to store the value in nanoseconds for > better precision; 2) use integers in constructors; 3) include overloaded > multiplication & division operators. (libstout) > - Try<Duration> Duration::create(double seconds) is added to work with a > floating-point seconds input. (libstout) > - Added a Time class as a new abstraction that works with Duration for > various time related calculations. (libprocess) > - Added a Try<Time> Time::create(double secs) corresponding to the > Duration::create() API. (libprocess) > - Changed various *time* variables to use the "Time" type instead of "double". > > > Diffs > ----- > > src/common/protobuf_utils.hpp 85d9ba7150a443a9b3170cdee74777a28270cd2b > src/exec/exec.cpp 1f022ca4aa1fd31a49c7792f59dea82b970569a3 > src/java/jni/org_apache_mesos_Log.cpp > a7cae14c402049f510534cb3850bbfccdfbb4848 > src/linux/cgroups.hpp 3e8682857572d208c2e888fcd566fa5f2e8989b3 > src/log/log.hpp 15ec072e029e76120c2ed48d48446330365585ab > src/log/network.hpp 0d9e9e337fa78ade41f359df523a766f24d7933c > src/master/constants.cpp 5d08645205b966625e9049b6468cee46b96ef4d8 > src/master/flags.hpp 8481baa99c231e466b26893d7ce7e45c629b7734 > src/master/hierarchical_allocator_process.hpp > 2422fbdc49fd575b615e73891e3cda6675358d2d > src/master/http.cpp 6d496f5d69f1b5c87ff5de36970613bad6cb205b > src/master/master.hpp d3790dc2e8b2446736e8b7bcb39c5df54a791237 > src/master/master.cpp c44f2b79eb2b2494b4cf3478f2566f3c117b2f83 > src/mesos/main.cpp 7983dd68cd8bb587c5fbe40114003635a5ebbff6 > src/sched/sched.cpp a55329488ae886f76fdf4576050cdeb5ead8026b > src/slave/cgroups_isolator.cpp 17a68dfc24969e466d22ebc4be0d89af86e028a6 > src/slave/constants.cpp 5a81f1fd1624677a6564a689967c0186e2fa89fd > src/slave/gc.cpp 611977406110b3cfcd8883e7a33b85ac9098e312 > src/slave/http.cpp 32a742aba0326caf43076c542c8f8ce3a3834d18 > src/slave/monitor.cpp ed62bb50835ddc3fd06964b9f920c7305aaff610 > src/slave/process_isolator.cpp 2224d62d7a9604032cc3ba2656849135540d6bd9 > src/slave/reaper.cpp b4d8912fa4a5910b0003c06b87a7fbc6164a6382 > src/slave/slave.hpp 82d2804446c658c4cde4d4fcfad2c8eaeec8b788 > src/slave/slave.cpp d3126cc072cbf17cbc5cc18be4bfa4840886fb16 > src/tests/cgroups_tests.cpp 3734315360fc1fb33a487696123a685aa18c9620 > src/tests/fault_tolerance_tests.cpp > 68cd5fcff266d102d8edf265776517aa2eef6061 > src/tests/isolator_tests.cpp 435c780f05b5bc78d1dc4e9cbcbac74971607dc9 > src/tests/log_tests.cpp 57fb9db5ef79f5e285eb2624bdfe25375fb8598e > src/tests/monitor_tests.cpp 9973f98c35415cb72e8f5124bf4d7ff402490a39 > src/zookeeper/group.cpp 159454e9fd6a8c05413d6ac2fe178b704a5ba8c4 > third_party/libprocess/Makefile.am d9d9110cc75d71642e621097bbc8bdcb88fdc0f8 > third_party/libprocess/include/process/clock.hpp > 46b737dcd680a770193dbee9ba2ffd796ec48abd > third_party/libprocess/include/process/future.hpp > cbe50af9c97e63f4837e7956fbccdf9a8deb3cd7 > third_party/libprocess/include/process/latch.hpp > 4c7982fdcc53bbedc2ebe698acd1c29ffa16c0a2 > third_party/libprocess/include/process/process.hpp > 513431481a1c9d4f445958960cd001f2d1bb1c81 > third_party/libprocess/include/process/statistics.hpp > 3f56c078d8609041c80c312aa9a42ed24ca42e60 > third_party/libprocess/include/process/time.hpp PRE-CREATION > third_party/libprocess/include/process/timeout.hpp > a907af19c9faa1c87864c5294a8e833bdca60252 > third_party/libprocess/src/process.cpp > edcb684332590f0277bafb2d69de68413fc82828 > third_party/libprocess/src/statistics.cpp > e1fb319eff63e4b7a4c18dba43e4818018b0dd50 > third_party/libprocess/src/tests/process_tests.cpp > 8fbf19676c54eb0da6f8daa042de127608bcb00b > third_party/libprocess/src/tests/statistics_tests.cpp > d6a53f79c8afe4cccebed2274f3dfdd1fe540d02 > third_party/libprocess/src/tests/time_tests.cpp PRE-CREATION > third_party/libprocess/third_party/stout/include/stout/duration.hpp > c943ab196871cf4c55f2a2dce5ef85ffe3a22577 > third_party/libprocess/third_party/stout/include/stout/os.hpp > 29f6fbda0ef0b5642358f32891a200e44acd4fe5 > third_party/libprocess/third_party/stout/tests/duration_tests.cpp > 421615aa510f540ccfc0413d3252bbdedd70f7da > > Diff: https://reviews.apache.org/r/11202/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jiang Yan Xu > >
