----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11289/ -----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler. Description ------- See summary. Works as expected on CentOS. But having issues getting make check to work on OSX. See below. Diffs ----- third_party/libprocess/third_party/Makefile.am b846173f44b1e2d5415231ef52eefcbc027f1aee third_party/libprocess/third_party/libev-3.8.patch 8f7ac91349134d638668d1beb9a6928167562fe2 third_party/libprocess/third_party/libev-3.8.tar.gz 6db7e888530916e138958da23cc89b2dfa858a8a third_party/libprocess/third_party/libev-4.15.patch PRE-CREATION third_party/libprocess/third_party/libev-4.15.tar.gz PRE-CREATION third_party/libprocess/third_party/versions.am b3a766a8e8e90ded88cb8720f372555dcc111322 Diff: https://reviews.apache.org/r/11289/diff/ Testing ------- All tests pass on CentOS-5.6. make passes on OSX 10.8. But make check on OSX 10.8 fails as follows: g++ -DPACKAGE_NAME=\"libprocess\" -DPACKAGE_TARNAME=\"libprocess\" -DPACKAGE_VERSION=\"0.0.1\" -DPACKAGE_STRING=\"libprocess\ 0.0.1\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE=\"libprocess\" -DVERSION=\"0.0.1\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -I. -I../../../third_party/libprocess -I../../../third_party/libprocess/src -Ithird_party/gmock-1.6.0/gtest/include -Ithird_party/gmock-1.6.0/include -I../../../third_party/libprocess/include -I../../../third_party/libprocess/third_party/stout/include -Ithird_party/boost-1.53.0 -Ithird_party/glog-0.3.1/src -Ithird_party/libev-4.15 -Ithird_party/ry-http-parser-1c3624a -g -MT tests-http_tests.o -MD -MP -MF .deps/tests-http_tests.Tpo -c -o tests-http_tests.o `test -f 'src/tests/http_tests.cpp' || echo '../../../third_party/libprocess/'`src/tests/http_tests.cpp In file included from ../../../third_party/libprocess/src/encoder.hpp:4, from ../../../third_party/libprocess/src/tests/encoder_tests.cpp:12: third_party/libev-4.15/ev.h:234: error: expected identifier before numeric constant third_party/libev-4.15/ev.h:234: error: expected `}' before numeric constant third_party/libev-4.15/ev.h:234: error: expected unqualified-id before numeric constant third_party/libev-4.15/ev.h:842: error: expected declaration before ‘}’ token make[5]: *** [tests-encoder_tests.o] Error 1 make[5]: *** Waiting for unfinished jobs.... In file included from ../../../third_party/libprocess/src/encoder.hpp:4, from ../../../third_party/libprocess/src/tests/http_tests.cpp:20: third_party/libev-4.15/ev.h:234: error: expected identifier before numeric constant third_party/libev-4.15/ev.h:234: error: expected `}' before numeric constant third_party/libev-4.15/ev.h:234: error: expected unqualified-id before numeric constant third_party/libev-4.15/ev.h:842: error: expected declaration before ‘}’ token make[5]: *** [tests-http_tests.o] Error 1 mv -f .deps/tests-decoder_tests.Tpo .deps/tests-decoder_tests.Po make[4]: *** [check-am] Error 2 make[3]: *** [check-recursive] Error 1 make[2]: *** [check-recursive] Error 1 make[1]: *** [check] Error 2 make: *** [check-recursive] Error 1 Thanks, Vinod Kone
