Got it thanks. P.S.: And yes, git master == svn trunk.
On Tue, May 21, 2013 at 4:49 PM, Mattmann, Chris A (398J) < [email protected]> wrote: > Hi Vinod, > > > -----Original Message----- > From: Vinod Kone <[email protected]> > Reply-To: "[email protected]" <[email protected] > > > Date: Tuesday, May 21, 2013 4:43 PM > To: "[email protected]" <[email protected]> > Subject: Re: [VOTE] Release Apache Mesos 0.11.0-incubating (RC1) > > >So the commit at > > > https://git-wip-us.apache.org/repos/asf?p=incubator-mesos.git;a=commit;h=1 > >647e682d6f02057f7375e53cf81d9048e53863c > > > >adds year to the Copyright line. > > > >>> >>> >Looks like the LICENSE information got attached to the NOTICE > >>>file, > > > >> >> >>> >instead > >> >> >>> >of LICENSE. Please update the LICENSE file accordingly and then > >> >>clean > >> >> >>>up > >> >> >>> >the NOTICE with required attributions. > >> > > Yep, my original intent was to deal with NOTICE required attributions. > However when I went to look at the NOTICE file they all seemed there. > So I didn't modify it. However had the msg all primed and pumped. Only > read mod I made was to the LICENSE file to update it with current year. > It's a minor nit, but may same us someone complaining during Incubator > review. > > > >> > >Also, in addition to not understanding the above comment, I don't think > >its > >been addressed on master branch? If not, can some one tell me what needs > >to > >be fixed? > > > >This is how my git diff looks: > > > >? ~/workspace/apache/mesos git:(0.11.x) git diff master -- NOTICE | cat > >diff --git a/NOTICE b/NOTICE > >index 752c4f3..6f9aee7 100644 > >--- a/NOTICE > >+++ b/NOTICE > >@@ -36,31 +36,7 @@ DEALINGS IN THE SOFTWARE. > > > > > > ====================================================================== > >-For boto (third_party/boto-2.0b2.zip): > >-====================================================================== > >- > >-Permission is hereby granted, free of charge, to any person obtaining a > >-copy of this software and associated documentation files (the > >-"Software"), to deal in the Software without restriction, including > >-without limitation the rights to use, copy, modify, merge, publish, dis- > >-tribute, sublicense, and/or sell copies of the Software, and to permit > >-persons to whom the Software is furnished to do so, subject to the fol- > >-lowing conditions: > >- > >-The above copyright notice and this permission notice shall be included > >-in all copies or substantial portions of the Software. > >- > >-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS > >-OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABIL- > >-ITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT > >-SHALL THE AUTHOR BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > >-WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, > >-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS > >-IN THE SOFTWARE. > >- > >- > >-====================================================================== > >-For distribute-0.6.26 (third_party/distribute-0.6.26.tar.gz): > >+For distribute-0.6.26: > > ====================================================================== > > > > PYTHON SOFTWARE FOUNDATION LICENSE VERSION 2 > > > > > >? ~/workspace/apache/mesos git:(0.11.x) git diff master -- LICENSE | cat > >diff --git a/LICENSE b/LICENSE > >index 00d351a..d645695 100644 > >--- a/LICENSE > >+++ b/LICENSE > >@@ -187,7 +187,7 @@ > > same "printed page" as the copyright notice for easier > > identification within third-party archives. > > > >- Copyright 2012-present Apache Software Foundation > >+ Copyright [yyyy] [name of copyright owner] > > > > Licensed under the Apache License, Version 2.0 (the "License"); > > you may not use this file except in compliance with the License. > > Yep you'll have to bear with me: is master the equivalent of SVN trunk? > If so, then then answer is that the master should have the copyright year > updated in its LICENSE file and that the NOTICE and DISCLAIMER files > look fine and are present. 0.11.0 RC should have those files present and > as they exist in the master. > > Does that make sense? > > Cheers, > Chris > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > Chris Mattmann, Ph.D. > Senior Computer Scientist > NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA > Office: 171-266B, Mailstop: 171-246 > Email: [email protected] > WWW: http://sunset.usc.edu/~mattmann/ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > Adjunct Assistant Professor, Computer Science Department > University of Southern California, Los Angeles, CA 90089 USA > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > >
