> On May 21, 2013, 10:14 p.m., Vinod Kone wrote: > > src/tests/exception_tests.cpp, lines 66-67 > > <https://reviews.apache.org/r/11280/diff/1/?file=294933#file294933line66> > > > > Why pull it out to temp when its not used anywhere else? > > > > Can't you just do ASSERT_SOME(StartSlave()) ? > > > > Here and everywhere else.
I was trying to stay consistent with the other tests so that the "boilerplate" was recognizable. Any reason not to do this? - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11280/#review20865 ----------------------------------------------------------- On May 20, 2013, 10:27 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11280/ > ----------------------------------------------------------- > > (Updated May 20, 2013, 10:27 p.m.) > > > Review request for mesos and Vinod Kone. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/exception_tests.cpp f405a61a7feb73e96b347d6c8e6fd316bdf6a1aa > src/tests/fault_tolerance_tests.cpp > 68cd5fcff266d102d8edf265776517aa2eef6061 > src/tests/resource_offers_tests.cpp > 5e53a89bcf99dedd4535545dc44a1a6229a09b0f > > Diff: https://reviews.apache.org/r/11280/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
