----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11270/#review21035 -----------------------------------------------------------
Ship it! lgtm as far as i understand. src/jvm/jvm.hpp <https://reviews.apache.org/r/11270/#comment43517> explain 'exceptions' arg - Vinod Kone On May 20, 2013, 10 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11270/ > ----------------------------------------------------------- > > (Updated May 20, 2013, 10 p.m.) > > > Review request for mesos and Vinod Kone. > > > Description > ------- > > I'll be factoring this out completely into a third-party library. But we'll > keep it here until we pull that out. > > > Diffs > ----- > > src/Makefile.am 343a7c5288e83d20dc6dd4db5353499199b90cb1 > src/jvm/java/io.hpp PRE-CREATION > src/jvm/java/lang.hpp PRE-CREATION > src/jvm/java/net.hpp PRE-CREATION > src/jvm/jvm.hpp 6a31bd855d4171d6c0a49e46226053379de47eb6 > src/jvm/jvm.cpp a4fb79136456316dab265facdbfbe599d181ba8f > src/jvm/org/apache/log4j.hpp PRE-CREATION > src/jvm/org/apache/log4j.cpp PRE-CREATION > src/jvm/org/apache/zookeeper.hpp PRE-CREATION > src/tests/zookeeper_test.hpp b5215b00973c9168f681832085bb29f6a8db8160 > src/tests/zookeeper_test.cpp fb61f2d9a5f431496e459807d6723ec12cf7ec55 > src/tests/zookeeper_test_server.hpp > bfa841c5375d01143fcd9b74db6ffe3b89c76643 > src/tests/zookeeper_test_server.cpp > 5c82a1eecfb311e344db476247b75d6b6d0d1564 > > Diff: https://reviews.apache.org/r/11270/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
