----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11466/#review21117 -----------------------------------------------------------
Ship it! src/mesos/main.cpp <https://reviews.apache.org/r/11466/#comment43866> why not kill this file/target altogether? - Vinod Kone On May 28, 2013, 5:39 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11466/ > ----------------------------------------------------------- > > (Updated May 28, 2013, 5:39 p.m.) > > > Review request for mesos and Vinod Kone. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am 644e1ca6b5ab9a73451ab2cf332da4d5043d4b86 > src/configurator/configuration.hpp 95effd24c8a72a63eec56c7ab5b12e2dddf098f7 > src/configurator/configuration.cpp fded13c90d7e76485d0b00948fb56857158c01ac > src/configurator/configurator.hpp 8449e05ae027e968c3a73b801df02fa7133807b0 > src/configurator/configurator.cpp bf45939a30508a36519204dc2f8afa061fddc691 > src/configurator/get_conf.cpp aa2bb7bdb5e7827c86db3539a9e69ff40964dd3b > src/configurator/option.hpp fc79491ca7f1ead636d9a3069e8f966d6445db77 > src/examples/test_framework.cpp b3608bad1a9b0bc3f89660d934207802051a5099 > src/flags/flag.hpp 46509f74eed4517281c93a5c505b785dffb6e956 > src/flags/flags.hpp 5a9c30cdd918709e84d15ed79eed01a7db3f0e45 > src/flags/loader.hpp 222617228c421e80db7e853bfd5011030db7d445 > src/flags/parse.hpp 88923fe815b5a0cfed408f73789557c9b50a3f5c > src/local/flags.hpp 75cd15a26b8fa2d1d54ba73a0a5ae7ec40ea4d20 > src/local/local.hpp 51324e285dd4638ccbc4a1124b7981e32fd5a779 > src/local/local.cpp eb33e5d71274f559898634e191c976efb2c749ec > src/local/main.cpp d2e632aa58616efcd798f99ba8ae02ca61bb3695 > src/log/main.cpp 24b9d8bd041986c41d7bf2fa76f3bd449eca0680 > src/logging/flags.hpp 4a963166620005337088eba5b30bd806fac5a943 > src/logging/logging.hpp 0e90ef1428f9ef12510eb5843d0e1d4b01e1cbcb > src/master/flags.hpp 23154f3d3eda8ac5bc48bfa2ca1ce86e7cf62637 > src/master/main.cpp 06c265af6fe289bc468a390207757c806fddda3c > src/master/master.hpp 38d2a51dd206ae3e63417d0193c8fe5b9256f815 > src/master/master.cpp 5ee7763fbd04fb0aab4a3bd4dda15b6119688e66 > src/mesos/main.cpp e7d083713b7db5a6b57ff9918bada1ca823625ad > src/sched/sched.cpp e19251bf7cd05c9532d8c30e086b4ef01784ea84 > src/slave/flags.hpp f3cbe3d5b633e149a349c4ec9784ac5ebfbd4325 > src/slave/main.cpp 97c818a753c4616c380ac75a570bd60b1df1cd49 > src/tests/allocator_tests.cpp 52e2b0319cfdefc90ae70efdec4c6f19433a3880 > src/tests/configurator_tests.cpp b82f5c27f5f695840555241516877c4e09cb7890 > src/tests/environment.cpp d8bb5fdcbe6da59385d7d10f96e314b0d4e98f85 > src/tests/flags.hpp 6ba5ecac45e12f15d98829cca2817a6c7f813204 > src/tests/flags_tests.cpp d52d4dbba33a95a82adec64e3d61bde62cb94d58 > src/tests/main.cpp 868bdd586717fd2e6a01c02e4080c1b2b49896c5 > > Diff: https://reviews.apache.org/r/11466/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
