----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11542/#review21198 -----------------------------------------------------------
loved the tests! 3rdparty/libprocess/3rdparty/stout/include/stout/bandwidth.hpp <https://reviews.apache.org/r/11542/#comment44024> s/support/supports/ 3rdparty/libprocess/3rdparty/stout/include/stout/bandwidth.hpp <https://reviews.apache.org/r/11542/#comment44025> how about "bps", "kbps" etc too? also kbit, mbit etc doesn't make sense for bandwidth no? 3rdparty/libprocess/3rdparty/stout/include/stout/bandwidth.hpp <https://reviews.apache.org/r/11542/#comment44028> was the compiler complaining about the lack of cast here? 3rdparty/libprocess/3rdparty/stout/include/stout/bandwidth.hpp <https://reviews.apache.org/r/11542/#comment44029> how about calling these functions bps(), kbps() etc? 3rdparty/libprocess/3rdparty/stout/tests/bandwidth_tests.cpp <https://reviews.apache.org/r/11542/#comment44030> outer elements should be separated by 2 lines. here and everywhere below. 3rdparty/libprocess/3rdparty/stout/tests/bandwidth_tests.cpp <https://reviews.apache.org/r/11542/#comment44031> can we test a good constructor too? 3rdparty/libprocess/3rdparty/stout/tests/bandwidth_tests.cpp <https://reviews.apache.org/r/11542/#comment44032> sweet! 3rdparty/libprocess/3rdparty/stout/tests/bandwidth_tests.cpp <https://reviews.apache.org/r/11542/#comment44033> woah. this is hard to comprehend. can we simpler numbers here? - Vinod Kone On May 30, 2013, 5:59 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11542/ > ----------------------------------------------------------- > > (Updated May 30, 2013, 5:59 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > - This implementation uses Boost::rational<uint64_t> to store both the bits > and the nanoseconds as integers to preserve precision. > - It requires the boost lib to be repackaged to include Boost::rational. > - The usage 'rational' handles avoid overflow cases better (it doesn't) than > simply multiply the denominators in various arithmetic operations. > - Bandwidth always >= 0 > - Bandwidth constructor passes 'boost::bad_rational' up when the denominator > is zero. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > 7a9ede62145e3150f7af6675d4384feafd9c0a88 > 3rdparty/libprocess/3rdparty/boost-1.53.0.tar.gz > 770d837aaba23d031b04ad77658f339587174aae > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 84062a0e1dfe4ec04bac7cac5ebaac4b945eb66e > 3rdparty/libprocess/3rdparty/stout/include/stout/bandwidth.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/bandwidth_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/11542/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jiang Yan Xu > >
