-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11547/#review21206
-----------------------------------------------------------

Ship it!



src/linux/cgroups.hpp
<https://reviews.apache.org/r/11547/#comment44057>

    Wrap please.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/11547/#comment44058>

    Wrap please.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/11547/#comment44059>

    How about a comment explaining why we are doing this?



src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/11547/#comment44055>

    ... for testing, retrying as necessary since the previous unmount might not 
have taken effect yet ... 



src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/11547/#comment44056>

    Quick comment explaining the '10'.


- Benjamin Hindman


On May 30, 2013, 8:17 p.m., Thomas Marshall wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11547/
> -----------------------------------------------------------
> 
> (Updated May 30, 2013, 8:17 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp 84edc97 
>   src/linux/cgroups.cpp cfdc3b2 
>   src/tests/cgroups_tests.cpp f6b23c4 
> 
> Diff: https://reviews.apache.org/r/11547/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Marshall
> 
>

Reply via email to