> On June 1, 2013, 1:07 a.m., Ben Mahler wrote: > > third_party/libprocess/src/encoder.hpp, line 222 > > <https://reviews.apache.org/r/11184/diff/1/?file=292302#file292302line222> > > > > Am I missing context here? Seems like this wouldn't tell us whether > > we're closing any libev pipes, since we're not checking the result of > > os::close here and elsewhere?
Oh I see https://reviews.apache.org/r/11170, disregard :) - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11184/#review21282 ----------------------------------------------------------- On May 15, 2013, 7:11 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11184/ > ----------------------------------------------------------- > > (Updated May 15, 2013, 7:11 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > third_party/libprocess/include/process/socket.hpp > f466963135aef490e08256768c36eb33ff4e2a56 > third_party/libprocess/src/encoder.hpp > 12b3ffaa4a63e33e096a26b514753eda61131a51 > third_party/libprocess/src/httpd.cpp > 49bcecef3f35d08679919266eb78fc3e27e5c45f > third_party/libprocess/src/net.hpp 8359526ac9bfb23360c5e9dac5bbf7379c78256c > third_party/libprocess/src/process.cpp > 197611fffe1d6f76b011211cf153a41c79c125a1 > > Diff: https://reviews.apache.org/r/11184/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
